1020115 - Lockscreen Visual Refresh follow-up

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #950884 +++

According to bug 950884 comment 50 we still have follow up to do. 

Howie, how do we track this? What's the schedule requirement of this follow up?

John, do you have time to address this?

Comment 1

[howie [:howie]]

Let's try the first sprint of v2.0 stabilization

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

> 1) Missing gradient layer on the top of lock screen, when there is no notifications, it should show a light gradient layer on the top of the background image. 
Will be fixed.

> 2) Time font: It's not Fira Sans Ultra Light yet, but updates for this should happen when font landed into the device. 
The CSS rule is already specifying for Ultra Light (weight 200). As soon as the font resource lands into phone's assets, it will automatically take effects.
  
> 3) The "Toggle arrows” is a bit fuzzy, looks like it stretch a little bit so it should be shorter than the gray toggle circle also.
Will investigate this

> 4) Unlock background stroke is a bit heavy, Stroke Gradient Opacity is: Top 100%, Bottom 0%
Will fix

> 5) On the Pin lock screen, the camera icon is not centered.
Will fix 

> 6) The clear bottom is incorrect size of the Pin lock keypad. 
"Button" right? It is currently a picture, but I think for consistency (with the real num keypad) we can change it to a character symbol.

> 7) Notification is missing arrow icon, and also scrolling up with “Time” is not showing. But according to your feedback, we are not able to have this function right now. 
> Yep, this will involve quite some engineering efforts (listening into scroll events, scrolling the disjoint header and notification elements, and so on).

> Note that notification gradient may still a bit greenish, maybe we can adjust this a bit.
Yep, I'm going to adjust it.

Comment 3

[Fang Shih [:fang]]

Attachment: pin code.png

Hi John,

Thanks for the replies : )
I just noticed that the pin code background overlay looks a bit greenish also. It should be #333333 with 30% transparency. I've attached the reference image.  Thanks again!!

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: lockscreen_with_top_gradient.png

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: lockscreen_without_top_gradient.png

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

Hi Fang,

Regarding the first issue (top gradient when there are no notifications): The spec in bug 950884 says #000000 opacity 20% to 0%, which would render like https://bug1020115.bugzilla.mozilla.org/attachment.cgi?id=8435515 (with gradient) and https://bug1020115.bugzilla.mozilla.org/attachment.cgi?id=8435517 (without gradient), which is quite visually different from the first screenshot in the spec. Could you double-confirm the gradient spec? Thanks.

Comment 7

[John Lu [:mnjul][Please NI or I'll miss]]

Sitrep:

> 1) Missing gradient layer on the top of lock screen, when there is no notifications, it should show a light gradient layer on the top of the background image. 
Waiting for question in comment 6 to clear

> 3) The "Toggle arrows” is a bit fuzzy, looks like it stretch a little bit so it should be shorter than the gray toggle circle also.
I made it a separate bug 1021479; fix already landed

> 4) Unlock background stroke is a bit heavy, Stroke Gradient Opacity is: Top 100%, Bottom 0%
Fixed in my local working branch

> 5) On the Pin lock screen, the camera icon is not centered.
Fixed in my local working branch

> 6) The clear bottom is incorrect size of the Pin lock keypad. 
On my pending list..

> Note that notification gradient may still a bit greenish, maybe we can adjust this a bit. Thanks!
Fixed in my local working branch

> I just noticed that the pin code background overlay looks a bit greenish also. It should be #333333 with 30% transparency. I've attached the reference image.
Fixed in my local working branch

Comment 8

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8436624 [details] [review]
Patch

Simple changes and it passed all tests.

Comment 10

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/9bdb051610c7019eb1f0324b9ebcea06862821d8

Comment 11

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8436624 [details] [review]
Patch

Hi Fang, 

I've just made all the modifications (except for issue 7) into our master branch. When they're available to you, please review the visual changes for me. Or I can demo to you with my phone. Many thanks!

Comment 12

[Hung Nguyen]

Attachment: 1020115_LS_IconUpdates.zip

Hey John 

We're looking to do a straight asset swap of a couple of icons (arrow and lock). If you could help with this, that would be fantastic. 

Please let me know if you have any questions. 

Thanks
Hung

Comment 13

[John Lu [:mnjul][Please NI or I'll miss]]

Hi Hung,
Image assets swap will be a separate bug; please see bug 1024845, thanks.

Comment 14

[Stephany Wilkes]

Fang, please let me know how ui-review? is coming along. That flag is five days old.

Comment 15

[bhavana bajaj [:bajaj]]

Clearing blocking on the meta-bug, the individual unresolved dependencies will be considered for blocking.

Comment 16

[Stephany Wilkes]

Team, is this a true meta bug or not?

This is not a meta bug if there are ui-review? flags set on patches. If it is intended as a meta, it can't be resolved as fixed when it still has open child bugs.

Also, what is happening with the ui-review? flag that is now ELEVEN days old?!

Comment 17

[Carol Huang [:Carol]]

Comment on attachment 8436624 [details] [review]
Patch

Hi John,
We've checked the patch. 
The only thing is that on issue 1, we didn't see the gradient on the top of screen.
Could follow the spec to add the gradient which is #000000 opacity 20% to 0%.
Thank you!

Comment 18

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: 2014-06-20-16-04-47_current.png

Comment 19

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: 2014-06-20-16-17-18_no_grad.png

Comment 20

[John Lu [:mnjul][Please NI or I'll miss]]

Hi Carol,

I understand the gradient is quite faint, but it is indeed there. Screenshot in comment 18 shows what we have right now. Screenshot comment 19 shows what it would have been if the gradient was not there.

In fact, I had discussed with Fang before landing the patch for the issue, and we had agreed upon the gradient being #000000 from opacity 30% to 0%.

Comment 21

[John Lu [:mnjul][Please NI or I'll miss]]

Hi Carol,

I'd like to know if the ui-review+ is coming along after my explanation in comment 20 and our offline discussion earlier? Thanks.

Comment 22

[Carol Huang [:Carol]]

Comment on attachment 8436624 [details] [review]
Patch

Hi John,
I flash the master and the gradient is good!
Thank you!